Fix some inconsistencies with memory freeing in pg_createsubscriber The correct function documented to free the memory allocated for the result returned by PQescapeIdentifier() and PQescapeLiteral() is PQfreemem(). pg_createsubscriber.c relied on pg_free() instead, which is not incorrect as both do a free() internally, but inconsistent with the documentation.
While on it, this commit fixes a small memory leak introduced by 4867f8a555ce, as the code of pg_createsubscriber makes this effort. Author: Ranier Vilela Reviewed-by: Euler Taveira Discussion: https://postgr.es/m/CAEudQAp=AW5dJXrGLbC_aZg_9nOo=42w7uldronfqe-gcgn...@mail.gmail.com Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ff6d9cfcb17e48c313aefe8fc65cdaeacd8766bf Modified Files -------------- src/bin/pg_basebackup/pg_createsubscriber.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-)
