Drop opcintype from index AM strategy translation API The type argument wasn't actually really necessary. It was a remnant of converting the API of the gist strategy translation from using opclass to using opfamily+opcintype (commits c09e5a6a016, 622f678c102). For looking up the gist translation function, we used the convention "amproclefttype = amprocrighttype = opclass's opcintype" (see pg_amproc.h). But each operator family should only have one translation function, and getting the right type for the lookup is sometimes cumbersome and fragile, so this is all unnecessarily complicated.
To simplify this, change the gist stategy support procedure to take "any", "any" as argument. (This is arbitrary but seems intuitive. The alternative of using InvalidOid as argument(s) upsets various DDL commands, so it's not practical.) Then we don't need opcintype for the lookup, and we can remove it from all the API layers introduced by commit c09e5a6a016. This also adds some more documentation about the correct signature of the gist support function and adds more checks in gistvalidate(). This was previously underspecified. (It relied implicitly on convention mentioned above.) Discussion: https://www.postgresql.org/message-id/flat/e72eaa49-354d-4c2e-8eb9-255197f55...@enterprisedb.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7d6d2c4bbd730bd9af191d46d4fb01d5f5c30cf1 Modified Files -------------- contrib/btree_gist/btree_gist--1.7--1.8.sql | 52 ++++++++++++++--------------- doc/src/sgml/gist.sgml | 6 ++++ src/backend/access/gist/gistutil.c | 4 +-- src/backend/access/gist/gistvalidate.c | 4 ++- src/backend/access/hash/hash.c | 4 +-- src/backend/access/index/amapi.c | 8 ++--- src/backend/access/nbtree/nbtree.c | 4 +-- src/backend/catalog/index.c | 1 - src/backend/commands/indexcmds.c | 2 +- src/backend/commands/tablecmds.c | 2 +- src/backend/executor/execReplication.c | 2 +- src/backend/replication/logical/relation.c | 6 ++-- src/include/access/amapi.h | 8 ++--- src/include/access/gist.h | 2 +- src/include/access/hash.h | 4 +-- src/include/access/nbtree.h | 4 +-- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_amproc.dat | 24 ++++++------- 18 files changed, 72 insertions(+), 67 deletions(-)
