Remove now-dead code in StoreAttrDefault(). StoreAttrDefault() is no longer responsible for filling attmissingval, so remove the code for that.
Get rid of RawColumnDefault.missingMode, too, as we no longer need that to pass information around. While here, clean up some sloppy coding in StoreAttrDefault(), such as failure to use XXXGetDatum macros. These aren't bugs but they're not good code either. Reported-by: jian he <jian.universal...@gmail.com> Author: jian he <jian.universal...@gmail.com> Author: Tom Lane <t...@sss.pgh.pa.us> Discussion: https://postgr.es/m/CACJufxHFssPvkP1we7WMhPD_1kwgbG52o=kqgl+tnvox5lo...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4528768d98f83070d625207dcb526982fb18f1ce Modified Files -------------- src/backend/catalog/heap.c | 5 ++- src/backend/catalog/pg_attrdef.c | 77 ++++------------------------------------ src/backend/commands/tablecmds.c | 8 ++--- src/include/catalog/heap.h | 1 - src/include/catalog/pg_attrdef.h | 3 +- 5 files changed, 11 insertions(+), 83 deletions(-)
