Fix race condition in TAP test 007_pre_auth The authentication test added in c76db55c9085 expects a backend to start and wait at the injection point "init-pre-auth". A query is used to retrieve the PID of the backend waiting at authentication, but its WHERE clause was too soft, checking only for a backend in a "starting" state.
As proved by the CI, this WHERE clause is not enough. There is a small window between the moment when the backend is reported as "starting" in its backend entry and the moment when it waits in its injection point, and it was possible for the test to return the PID of a backend process not yet waiting in the injection point, causing spurious failures. This issue is fixed by tweaking the query retrieving the PID of the backend waiting before authentication so as we check for "init-pre-auth" in its wait_event. An extra check based on the backend_type is added, based on a suggestion by Jacob, to be more cautious. Error spotted by the CI on Windows, but it could happen anywhere, as long as the authentication path is slow enough compared to the TAP test. Reported-by: Andres Freund <and...@anarazel.de> Author: Jacob Champion <jacob.champ...@enterprisedb.com> Co-authored-by: Michael Paquier <mich...@paquier.xyz> Discussion: https://postgr.es/m/soexrl7oeyku24bj3czupxmv27ow35u6edymp5y3oyoysbe2kb@r3tgoos2xp2x Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e2080261cc8c1a962708843dc4c806e19fb2c44e Modified Files -------------- src/test/authentication/t/007_pre_auth.pl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
