Preserve RangeTblEntry.relid when expanding a view RTE. When the rewriter converts an RTE_RELATION RTE for a view into an RTE_SUBQUERY RTE containing the view's defining query, leave the relid field alone instead of zeroing it. This allows the planner to tell that the subquery came from a view rather than having been written in-line, which is needed to support an upcoming planner bug fix. We cannot change the behavior of the outfuncs/readfuncs code in released branches, so the relid field will not survive in plans passed to parallel workers; therefore this info should not be relied on in the executor.
This back-patches a portion of the data structure definitional changes made in v16 and up by commit 47bb9db75. It's being committed separately for visibility in the commit log, but with luck it will not actually matter to anyone. While it's not inconceivable that this change will break code expecting relid to be zero in a subquery RTE, we can hope that such code has already been adjusted to cope with v16 and up. Reported-by: Duncan Sands <duncan.sa...@deepbluecap.com> Diagnosed-by: Tender Wang <tndrw...@gmail.com> Author: Tom Lane <t...@sss.pgh.pa.us> Reviewed-by: Dean Rasheed <dean.a.rash...@gmail.com> Discussion: https://postgr.es/m/3518c50a-ab18-482f-b916-a37263622...@deepbluecap.com Backpatch-through: 13-15 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/584f17a9063ee63aa472705bfac1bed95e3e2194 Modified Files -------------- src/backend/rewrite/rewriteHandler.c | 8 ++++++-- src/include/nodes/parsenodes.h | 6 ++++++ 2 files changed, 12 insertions(+), 2 deletions(-)
