Build whole-row Vars the same way during parsing and planning. makeWholeRowVar() has different rules for constructing a whole-row Var depending on the kind of RTE it's representing. This turns out to be problematic because the rewriter and planner can convert view RTEs and set-returning-function RTEs into subquery RTEs; so a whole-row Var made during planning might look different from one made by the parser. In isolation this doesn't cause any problem, but if a query contains Vars made both ways for the same varno, there are cross-checks in the executor that will complain. This manifests for UPDATE, DELETE, and MERGE queries that use whole-row table references.
To fix, we need makeWholeRowVar() to produce the same result from an inlined RTE as it would have for the original. For an inlined view, we can use RangeTblEntry.relid to detect that this had been a view RTE. For inlined SRFs, make a data structure definition change akin to commit 47bb9db75, and say that we won't clear RangeTblEntry.functions until the end of planning. That allows makeWholeRowVar() to repeat what it would have done with the unmodified RTE. Reported-by: Duncan Sands <duncan.sa...@deepbluecap.com> Reported-by: Dean Rasheed <dean.a.rash...@gmail.com> Diagnosed-by: Tender Wang <tndrw...@gmail.com> Author: Tom Lane <t...@sss.pgh.pa.us> Reviewed-by: Dean Rasheed <dean.a.rash...@gmail.com> Discussion: https://postgr.es/m/3518c50a-ab18-482f-b916-a37263622...@deepbluecap.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/39af32f7883f5e3072aaa8b9c0c6bab7230ee3a3 Modified Files -------------- src/backend/nodes/makefuncs.c | 51 +++++++++++++++++++++++++-- src/backend/optimizer/prep/prepjointree.c | 10 ++++-- src/test/regress/expected/returning.out | 57 +++++++++++++++++++++++++++++++ src/test/regress/sql/returning.sql | 24 +++++++++++++ 4 files changed, 138 insertions(+), 4 deletions(-)
