Apply more consistent style for command options in TAP tests This commit reshapes the grammar of some commands to apply a more consistent style across the board, following rules similar to ce1b0f9da03e: - Elimination of some pointless used-once variables. - Use of long options, to self-document better the options used. - Use of fat commas to link option names and their assigned values, including redirections, so as perltidy can be tricked to put them together.
Author: Dagfinn Ilmari Mannsåker <ilm...@ilmari.org> Discussion: https://postgr.es/m/87jz8rzf3h....@wibble.ilmari.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/19c6e92b13b2336d1db1b236457ab15d0894b506 Modified Files -------------- contrib/auto_explain/t/001_auto_explain.pl | 2 +- contrib/basebackup_to_shell/t/001_basic.pl | 6 +- contrib/sepgsql/t/001_sepgsql.pl | 3 +- .../pg_archivecleanup/t/010_pg_archivecleanup.pl | 9 +- src/bin/pg_resetwal/t/002_corrupted.pl | 3 +- src/bin/pg_rewind/t/009_growing_files.pl | 3 +- src/bin/pg_rewind/t/RewindTest.pm | 21 +-- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 74 ++++++---- src/bin/pg_upgrade/t/003_logical_slots.pl | 14 +- src/bin/pg_upgrade/t/005_char_signedness.pl | 37 ++--- src/bin/pg_verifybackup/t/002_algorithm.pl | 13 +- src/bin/pg_verifybackup/t/003_corruption.pl | 4 +- src/bin/pg_verifybackup/t/004_options.pl | 3 +- src/bin/pg_verifybackup/t/008_untar.pl | 20 ++- src/bin/pg_verifybackup/t/009_extract.pl | 25 ++-- src/bin/pg_verifybackup/t/010_client_untar.pl | 17 ++- src/bin/pg_waldump/t/001_basic.pl | 24 ++-- src/bin/pgbench/t/001_pgbench_with_server.pl | 2 +- src/bin/pgbench/t/002_pgbench_no_server.pl | 2 +- src/bin/psql/t/001_basic.pl | 5 +- src/bin/psql/t/020_cancel.pl | 9 +- src/interfaces/libpq/t/001_uri.pl | 5 +- src/interfaces/libpq/t/005_negotiate_encryption.pl | 4 +- src/test/modules/commit_ts/t/003_standby_2.pl | 2 +- .../modules/libpq_pipeline/t/001_libpq_pipeline.pl | 4 +- .../ssl_passphrase_callback/t/001_testfunc.pl | 8 +- src/test/modules/test_pg_dump/t/001_base.pl | 159 ++++++++++++--------- src/test/perl/PostgreSQL/Test/BackgroundPsql.pm | 9 +- src/test/perl/PostgreSQL/Test/Cluster.pm | 140 +++++++++++------- src/test/perl/PostgreSQL/Test/Kerberos.pm | 2 +- src/test/perl/PostgreSQL/Test/Utils.pm | 40 +++--- src/test/postmaster/t/002_connection_limits.pl | 5 +- src/test/recovery/t/001_stream_rep.pl | 48 ++++--- src/test/recovery/t/006_logical_decoding.pl | 7 +- src/test/recovery/t/013_crash_restart.pl | 29 ++-- src/test/recovery/t/017_shm.pl | 18 ++- src/test/recovery/t/021_row_visibility.pl | 30 ++-- src/test/recovery/t/022_crash_temp_files.pl | 30 ++-- src/test/recovery/t/032_relfilenode_reuse.pl | 30 ++-- .../recovery/t/035_standby_logical_decoding.pl | 36 ++--- .../recovery/t/040_standby_failover_slots_sync.pl | 2 +- src/test/recovery/t/041_checkpoint_at_promote.pl | 15 +- src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl | 2 +- 43 files changed, 522 insertions(+), 399 deletions(-)
