In XLogFileInit(), fix *use_existent postcondition to suit callers. Infrequently, the mismatch caused log_checkpoints messages and TRACE_POSTGRESQL_CHECKPOINT_DONE() to witness an "added" count too high by one. Since that consequence is so minor, no back-patch.
This commit has been applied as of 85656bc3050f in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me, Noah Misch is the author. Tests have been conducted by the both of us. Reported-by: Arun Thirupathi Author: Noah Misch <n...@leadboat.com> Discussion: https://postgr.es/m/20210202151416.gb3304...@rfd.leadboat.com Discussion: https://postgr.es/m/20250306193013.36.nmi...@google.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8967dddf086e81b0b5ee84a197cc2773f73e131a Author: Noah Misch <n...@leadboat.com> Modified Files -------------- src/backend/access/transam/xlog.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
