Stabilize 035_standby_logical_decoding.pl. Some tests try to invalidate logical slots on the standby server by running VACUUM on the primary. The problem is that xl_running_xacts was getting generated and replayed before the VACUUM command, leading to the advancement of the active slot's catalog_xmin. Due to this, active slots were not getting invalidated, leading to test failures.
We fix it by skipping the generation of xl_running_xacts for the required tests with the help of injection points. As the required interface for injection points was not present in back branches, we fixed the failing tests in them by disallowing the slot to become active for the required cases (where rows_removed conflict could be generated). Author: Hayato Kuroda <kuroda.hay...@fujitsu.com> Reviewed-by: Bertrand Drouvot <bertranddrouvot...@gmail.com> Reviewed-by: Amit Kapila <amit.kapil...@gmail.com> Backpatch-through: 16, where it was introduced Discussion: https://postgr.es/m/z6oqxc8lmitlf...@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/105b2cb336173d7c62e26ad104682175ddad4cff Modified Files -------------- src/backend/storage/ipc/standby.c | 12 +++++ .../recovery/t/035_standby_logical_decoding.pl | 56 ++++++++++++++++------ 2 files changed, 54 insertions(+), 14 deletions(-)
