I just pushed my annual commit that makes function parameter names consistent between function declarations and their corresponding definitions, to cover the Postgres 18 cycle. The details there were all straightforward. But there are 2 remaining complaints from clang-tidy that seem worth fixing, that don't quite fall under any established policy in this area.
The first such complaint concerns a new mcxt.c function parameter that shadows a global variable in the same file -- attached patch fixes that by renaming the function parameter. Technically, this is a distinct type of complaint to the clang-tidy complaints that I ordinarily fix this time of year, though it's of the same general nature. The second such complaint is a standard "function parameter name is inconsistent" complaint, though it's one that affects vendored code in src/include/snowball/libstemmer/header.h. I attach a fix for that, too. In the past we have tended to treat cases with vendored code just like non-vendored Postgres code, but there's always a question about whether it's worth diverging from upstream. That needs to be decided on a case-by-case basis, and I don't know enough to know if I should proceed here. I have not attached a fix for a similar vendored code issue that appears in timingsafe_bcmp.c, since that involved a declaration provided by my system's openSSL being inconsistent with our own vendored definition. A fix for that seemed unnecessary. -- Peter Geoghegan
v1-0002-Make-libstemmer-param-name-consistent.patch
Description: Binary data
v1-0001-Stop-shadowing-global-variable-with-parameter-nam.patch
Description: Binary data
