On 4/16/25 18:34, Jacob Champion wrote: > On Wed, Apr 16, 2025 at 9:30 AM Daniel Gustafsson <dan...@yesql.se> wrote: >> It seems like this commit didn't run autoheader, which leaves a trivial diff >> in >> pg_config.h.in carried over for future callers. It doesn't change anuything >> really as the HAVE_LIBNUMA macro isn't used, but for completeness sake we >> should probably add it? > > +1, I ran autoreconf during a rebase today and had to undo the new NUMA hunks > :D > > Your patch looks the same as what I'm carrying locally. >
Ah, I didn't notice the autoheader thing. The patch looks fine to me. Daniel, do you intend to push it, or do you want me to do that? regards -- Tomas Vondra