Use strchr instead of strstr for single-char lookups Compilers such as gcc and clang seem to perform this rewrite automatically when the lookup string is known at compile-time to contain a single character. The MSVC compiler does not seem apply the same optimization, and the code being adjusted here is within an #ifdef WIN32, so it seems worth adjusting this with the assumption that strchr() will be slightly more performant.
There are a couple more instances in contrib/fuzzystrmatch that this commit could also have adjusted. After some discussion, we deemed those not important enough to bother with. Author: Dmitry Mityugov <d.mityu...@postgrespro.ru> Reviewed-by: Corey Huinker <corey.huin...@gmail.com> Reviewed-by: David Rowley <drowle...@gmail.com> Discussion: https://postgr.es/m/9c1beea6c7a5e9fb6677f26620f1f257%40postgrespro.ru Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/039f7ee0fe9a25cf26d915d4b68091e080c6c6ec Modified Files -------------- src/port/pgmkdirp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
