Add missing EPQ recheck for TID Scan The EvalPlanQual recheck for TID Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Scans where the ctid of the new (updated) tuple no longer matches the clause of the scan. This isn't desired behavior, and isn't consistent with what would happen if the chosen plan had used an Index or Seq Scan, and that could lead to hard to predict behavior for scans that contain TID quals and other quals as the planner has freedom to choose TID or some other scan method for such queries, and the chosen plan could change at any moment.
Here we fix this by properly implementing the recheck function for TID Scans. Backpatch to 13, oldest supported version Reported-by: Sophie Alpert <p...@sophiebits.com> Author: Sophie Alpert <p...@sophiebits.com> Author: David Rowley <dgrowle...@gmail.com> Reviewed-by: David Rowley <dgrowle...@gmail.com> Reviewed-by: Chao Li <li.evan.c...@gmail.com> Discussion: https://postgr.es/m/4a6268ff-3340-453a-9bf5-c98d51a6f...@app.fastmail.com Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/dee21ea6d6178f1acd5044fd94e3dc4542e2656b Modified Files -------------- src/backend/executor/nodeTidscan.c | 19 +++++-- src/test/isolation/expected/eval-plan-qual.out | 71 ++++++++++++++++++++++++++ src/test/isolation/specs/eval-plan-qual.spec | 11 ++++ 3 files changed, 97 insertions(+), 4 deletions(-)
