Add missing EPQ recheck for TID Range Scan The EvalPlanQual recheck for TID Range Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Range Scans where the ctid of the new (updated) tuple no longer matches the clause of the scan. This isn't desired behavior, and isn't consistent with what would happen if the chosen plan had used an Index or Seq Scan, and that could lead to hard to predict behavior for scans that contain TID quals and other quals as the planner has freedom to choose TID Range or some other non-TID scan method for such queries, and the chosen plan could change at any moment.
Here we fix this by properly implementing the recheck function for TID Range Scans. Backpatch to 14, where TID Range Scans were added Reported-by: Sophie Alpert <p...@sophiebits.com> Author: Sophie Alpert <p...@sophiebits.com> Author: David Rowley <dgrowle...@gmail.com> Reviewed-by: David Rowley <dgrowle...@gmail.com> Reviewed-by: Chao Li <li.evan.c...@gmail.com> Discussion: https://postgr.es/m/4a6268ff-3340-453a-9bf5-c98d51a6f...@app.fastmail.com Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ba0203880a8f2f8ae397f176f86ed1339939479c Modified Files -------------- src/backend/executor/nodeTidrangescan.c | 10 ++++++++++ src/test/isolation/expected/eval-plan-qual.out | 23 +++++++++++++++++++++++ src/test/isolation/specs/eval-plan-qual.spec | 5 ++++- 3 files changed, 37 insertions(+), 1 deletion(-)
