Use bms_add_members() instead of bms_union() when possible bms_union() causes a new set to be allocated. What this caller needs is members added to an existing set. bms_add_members() is the tool for that job.
This is just a matter of fixing an inefficiency due to surplus memory allocations. No bugs being fixed. The only other place I found that might be valid to apply this change is in markNullableIfNeeded(), but I opted not to do that due to the risk to reward ratio not looking favorable. The risk being that there *could* be another pointer pointing to the Bitmapset. Author: David Rowley <[email protected]> Reviewed-by: Greg Burd <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://postgr.es/m/caaphdvoccos-p5tznjltxfoktynjqvh7dwf+5ikdubwnvwf...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5092aae431e3e1a20324ea3a42a181c63f703d0d Modified Files -------------- src/backend/optimizer/prep/prepunion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
