Use ereport rather than elog in WinCheckAndInitializeNullTreatment. Previously WinCheckAndInitializeNullTreatment() used elog() to emit an error message. ereport() should be used instead because it's a user-facing error. Also use existing get_func_name() to get a function's name, rather than own implementation.
Moreover add an assertion to validate winobj parameter, just like other window function API. Reported-by: Tom Lane <[email protected]> Author: Tatsuo Ishii <[email protected]> Reviewed-by: Chao Li <[email protected]> Discussion: https://postgr.es/m/2952409.1760023154%40sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5f3808646f67260d5dc0d95f2602886da5cf5c52 Modified Files -------------- src/backend/executor/nodeWindowAgg.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-)
