Fix LOCK_TIMEOUT handling in slotsync worker. Previously, the slotsync worker relied on SIGINT for graceful shutdown during promotion. However, SIGINT is also used by the LOCK_TIMEOUT handler to cancel queries. Since the slotsync worker can lock catalog tables while parsing libpq tuples, this overlap caused it to ignore LOCK_TIMEOUT signals and potentially wait indefinitely on locks.
This patch replaces the slotsync worker's SIGINT handler with StatementCancelHandler to correctly process query-cancel interrupts. Additionally, the startup process now uses SIGUSR1 to signal the slotsync worker to stop during promotion. The worker exits after detecting that the shared memory flag stopSignaled is set. Author: Hou Zhijie <[email protected]> Reviewed-by: shveta malik <[email protected]> Reviewed-by: Chao Li <[email protected]> Reviewed-by: Amit Kapila <[email protected]> Backpatch-through: 17, here it was introduced Discussion: https://postgr.es/m/ty4pr01mb169078f33846e9568412d878c94...@ty4pr01mb16907.jpnprd01.prod.outlook.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f2818868aec856e7d2502e5232e08d3a4857a802 Modified Files -------------- src/backend/replication/logical/slotsync.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
