Clean up test_cloexec.c and Makefile. An unused variable caused a compiler warning on BF animal fairywren, an snprintf() call was redundant, and some buffer sizes were inconsistent. Per code review from Tom Lane.
The Makefile's test ifeq ($(PORTNAME), win32) never succeeded due to a circularity, so only Meson builds were actually compiling the new test code, partially explaining why CI didn't tell us about the warning sooner (the other problem being that CompilerWarnings only makes world-bin, a problem for another commit). Simplify. Backpatch-through: 16, like commit c507ba55 Author: Bryan Green <[email protected]> Co-authored-by: Thomas Munro <[email protected]> Reported-by: Tom Lane <[email protected]> Discussion: https://postgr.es/m/1086088.1765593851%40sss.pgh.pa.us Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0666ccc16cc2d1b97032e7723601dbf5300d057d Modified Files -------------- src/test/modules/test_cloexec/Makefile | 17 ++------ src/test/modules/test_cloexec/test_cloexec.c | 60 +++++++++------------------- 2 files changed, 23 insertions(+), 54 deletions(-)
