Fix query jumbling with GROUP BY clauses RangeTblEntry.groupexprs was marked with the node attribute query_jumble_ignore, causing a list of GROUP BY expressions to be ignored during the query jumbling. For example, these two queries could be grouped together within the same query ID: SELECT count(*) FROM t GROUP BY a; SELECT count(*) FROM t GROUP BY b;
However, as such queries use different GROUP BY clauses, they should be split across multiple entries. This fixes an oversight in 247dea89f761, that has introduced an RTE for GROUP BY clauses. Query IDs are documented as being stable across minor releases, but as this is a regression new to v18 and that we are still early in its support cycle, a backpatch is exceptionally done as this has broken a behavior that exists since query jumbling is supported in core, since its introduction in pg_stat_statements. The tests of pg_stat_statements are expanded to cover this area, with patterns involving GROUP BY and GROUPING clauses. Author: Jian He <[email protected]> Discussion: https://postgr.es/m/CACJufxEy2W+tCqC7XuJ94r3ivWsM=onkjp94krfx3hoarjb...@mail.gmail.com Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9c3caad0264011490134816b2264de7f20b2eb99 Modified Files -------------- contrib/pg_stat_statements/expected/select.out | 98 +++++++++++++++++++++++++- contrib/pg_stat_statements/sql/select.sql | 16 +++++ src/include/nodes/parsenodes.h | 2 +- 3 files changed, 114 insertions(+), 2 deletions(-)
