pg_recvlogical: Prevent flushed data from being re-sent. Previously, when pg_recvlogical lost connection, reconnected, and restarted replication, data that had already been flushed could be streamed again. This happened because the replication start position used when restarting replication was taken from the last standby status message, which could be older than the position of the last flushed data. As a result, some flushed data newer than the replication start position could exist and be re-sent.
This commit fixes the issue by ensuring all written data is flushed to disk before restarting replication, and by using the last flushed position as the replication start point. This prevents already flushed data from being re-sent. Additionally, previously when the --no-loop option was used, pg_recvlogical could exit without flushing written data, potentially losing data. To fix this issue, this commit also ensures all data is flushed to disk before exiting due to --no-loop. Author: Fujii Masao <[email protected]> Reviewed-by: Mircea Cadariu <[email protected]> Reviewed-by: Yilin Zhang <[email protected]> Reviewed-by: Dewei Dai <[email protected]> Reviewed-by: Chao Li <[email protected]> Discussion: https://postgr.es/m/CAHGQGwFeTymZQ7RLvMU6WuDGar8bUQCazg=vofa-9gebkg-...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/41cbdab0ab6d04e8ec42d10335ef9635eb9c2c67 Modified Files -------------- src/bin/pg_basebackup/pg_recvlogical.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-)
