pg_stat_statements: Fix crash in list squashing with Vars When IN/ANY clauses contain both constants and variable expressions, the optimizer transforms them into separate structures: constants become an array expression while variables become individual OR conditions.
This transformation was creating an overlap with the token locations, causing pg_stat_statements query normalization to crash because it could not calculate the amount of bytes remaining to write for the normalized query. This commit disables squashing for mixed IN list expressions when constructing a scalar array op, by setting list_start and list_end to -1 when both variables and non-variables are present. Some regression tests are added to PGSS to verify these patterns. Author: Sami Imseih <[email protected]> Reviewed-by: Dmitry Dolgov <[email protected]> Discussion: https://postgr.es/m/caa5rz0ts9qionnhjjhxpxteps22gbo4d3jz_s2bqc59an7x...@mail.gmail.com Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5d95219faa1a95b78202be9e25bdb2aeb30cb4dc Modified Files -------------- contrib/pg_stat_statements/expected/squashing.out | 22 +++++++++++++++++++++- contrib/pg_stat_statements/sql/squashing.sql | 6 ++++++ src/backend/parser/parse_expr.c | 13 +++++++++++-- 3 files changed, 38 insertions(+), 3 deletions(-)
