Improve errdetail for logical replication conflict messages. This change enhances the clarity and usefulness of error detail messages generated during logical replication conflicts. The following improvements have been made:
1. Eliminate redundant output: Avoid printing duplicate remote row and replica identity values for the multiple_unique_conflicts conflict type. 2. Improve message structure: Append tuple values directly to the main error message, separated by a colon (:), for better readability. 3. Simplify local row terminology: Remove the word 'existing' when referring to the local row, as this is already implied by context. 4. General code refinements: Apply miscellaneous code cleanups to improve how conflict detail messages are constructed and formatted. Author: Hayato Kuroda <[email protected]> Reviewed-by: Shveta Malik <[email protected]> Reviewed-by: Amit Kapila <[email protected]> Reviewed-by: Masahiko Sawada <[email protected]> Reviewed-by: Zhijie Hou <[email protected]> Discussion: https://postgr.es/m/cahut+psgkwy5-ygrjc15izecysggysrbcszv_z93ess8xtc...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/48efefa6caacba49ca5b7b84e20c900776e56c50 Modified Files -------------- doc/src/sgml/logical-replication.sgml | 23 ++- src/backend/replication/logical/conflict.c | 248 +++++++++++++++++------------ src/include/replication/conflict.h | 2 +- src/test/subscription/t/001_rep_changes.pl | 6 +- src/test/subscription/t/013_partition.pl | 14 +- src/test/subscription/t/029_on_error.pl | 2 +- src/test/subscription/t/030_origin.pl | 4 +- src/test/subscription/t/035_conflicts.pl | 42 +++-- 8 files changed, 192 insertions(+), 149 deletions(-)
