Fix use of proc number in pgstat_create_backend() This routine's internals directly used MyProcNumber to choose which object ID to assign for the hash key of a backend's stats entry, while the value to use is given as input argument of the function.
The original intention was to pass MyProcNumber as an argument of pgstat_create_backend() when called in pgstat_bestart_final(), pgstat_beinit() ensuring that MyProcNumber has been set, not use it directly in the function. This commit addresses this inconsistency by using the procnum given by the caller of pgstat_create_backend(), not MyProcNumber. This issue is not a cause of bugs currently. However, let's keep the code in sync across all the branches where this code exists, as it could matter in a future backpatch. Oversight in 4feba03d8b92. Reported-by: Ryo Matsumura <[email protected]> Discussion: https://postgr.es/m/tycpr01mb11316ad8150c8f470319accaee8...@tycpr01mb11316.jpnprd01.prod.outlook.com Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/072c8421359730149f4eaf861ce55aa78968ba9d Modified Files -------------- src/backend/utils/activity/pgstat_backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
