Fix test_valid_server_encoding helper function. Commit c67bef3f325 introduced this test helper function for use by src/test/regress/sql/encoding.sql, but its logic was incorrect. It confused an encoding ID for a boolean so it gave the wrong results for some inputs, and also forgot the usual return macro. The mistake didn't affect values actually used in the test, so there is no change in behavior.
Also drop it and another missed function at the end of the test, for consistency. Backpatch-through: 14 Author: Zsolt Parragi <[email protected]> Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ccc9be800dddf1662aa25aa4ee27aa71965b3fa9 Modified Files -------------- src/test/regress/expected/encoding.out | 2 ++ src/test/regress/regress.c | 2 +- src/test/regress/sql/encoding.sql | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-)
