Fix more multibyte issues in ltree. Commit 84d5efa7e3 missed some multibyte issues caused by short-circuit logic in the callers. The callers assumed that if the predicate string is longer than the label string, then it couldn't possibly be a match, but it can be when using case-insensitive matching (LVAR_INCASE) if casefolding changes the byte length.
Fix by refactoring to get rid of the short-circuit logic as well as the function pointer, and consolidate the logic in a replacement function ltree_label_match(). Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c8308a984d9dd45b3111bd99c8fba23cb78aeaa0 Modified Files -------------- contrib/ltree/lquery_op.c | 103 +++++++++++++++++++++---------------------- contrib/ltree/ltree.h | 10 ++--- contrib/ltree/ltxtquery_op.c | 11 +++-- 3 files changed, 60 insertions(+), 64 deletions(-)
