Remove WAL page header flag XLP_BKP_REMOVABLE There are no known users of this flag. The last supposed user was pglesslog, which is the reason why this flag has been introduced in core, based on an historical search pointing at a8d539f12498.
I have mentioned that we may want to remove this flag back in 2018, due to zero users of it in core. More recently, Noah has pointed out that this flag is not safe to use: XLP_BKP_REMOVABLE can be set by the WAL writer in a lock-free fashion with runningBackups > 0, meaning that some full-page images could be required but not logged, ultimately corrupting backups. Bump XLOG_PAGE_MAGIC. Author: Matthias van de Meent <[email protected]> Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/caeze2whiwksoavfuggjdeoey0-rz9ctpfrhcqvbmmjxv-k_...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f68d7e7483d240d8c92b8fc245a3a10199d426dd Modified Files -------------- src/backend/access/transam/xlog.c | 23 ----------------------- src/include/access/xlog_internal.h | 8 +++----- 2 files changed, 3 insertions(+), 28 deletions(-)
