Fix yet another bug in archive streamer with LZ4 decompression. The code path in astreamer_lz4_decompressor_content() that updated the output pointers when the output buffer isn't full was wrong. It advanced next_out by bytes_written, which could include previous decompression output not just that of the current cycle. The correct amount to advance is out_size. While at it, make the output pointer updates look more like the input pointer updates.
This bug is pretty hard to reach, as it requires consecutive compression frames that are too small to fill the output buffer. pg_dump could have produced such data before 66ec01dc4, but I'm unsure whether any files we use astreamer with would be likely to contain problematic data. Author: Chao Li <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4548e8746631e03d6e8c22eb708c1e5f410126b1 Modified Files -------------- src/bin/pg_basebackup/bbstreamer_lz4.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
