Simplify translatable messages for tuple value details in conflict.c. append_tuple_value_detail() constructed user-visible messages using separately translated fragments such as ": ", ", ", and ".",. This makes correct translation difficult or impossible in some languages.
Refactor append_tuple_value_detail() to move all punctuation and sentence construction to the callers, which now use a single translatable string with a %s placeholder for the tuple data. Reported-by: David Rowley <[email protected]> Author: vignesh C <[email protected]> Reviewed-by: Hayato Kuroda <[email protected]> Reviewed-by: Amit Kapila <[email protected]> Reviewed-by: Zhijie Hou <[email protected]> Reviewed-by: Peter Smith <[email protected]> Discussion: https://postgr.es/m/227279.1775956328%40sss.pgh.pa.us#8f3a5f50543556c60cc5a13270cb7ba4 Discussion: https://postgr.es/m/caaphdvohyodrvhvxxzcjnx_gymswbfjtttb6hgdauetz8na...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/bf3ead60751488f5c65434fa7ea770a9f6031db0 Modified Files -------------- src/backend/replication/logical/conflict.c | 223 +++++++++++++++++++---------- 1 file changed, 148 insertions(+), 75 deletions(-)
