pgbench: fix verbose error message corruption with multiple threads When pgbench runs with multiple threads and verbose error reporting is enabled (--verbose-errors), multiple clients can build verbose error messages concurrently. Previously, a function-local static PQExpBuffer was used for these messages, causing the buffer to be shared across threads. This was not thread-safe and could result in corrupted or incorrect log output.
Fix this by using a local PQExpBufferData instead of a static buffer. This keeps verbose error messages correct during concurrent execution. Backpatch to v15, where this issue was introduced. Author: Fujii Masao <[email protected]> Reviewed-by: Michael Paquier <[email protected]> Reviewed-by: Alex Guo <[email protected]> Reviewed-by: Chao Li <[email protected]> Discussion: https://postgr.es/m/CAHGQGwER1AjGXpkKB9t9820NBhMQ_Ghv7=HsKeodUr3=szs...@mail.gmail.com Backpatch-through: 15 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/52b3e7001cb3584ae9f95ac01a185a50cca988cb Modified Files -------------- src/bin/pgbench/pgbench.c | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-)
