Fix REPACK decoding worker not cleaned up on FATAL exit When the launching backend of REPACK (CONCURRENTLY) is terminated via pg_terminate_backend(), ProcDiePending causes ereport(FATAL) which bypasses PG_FINALLY blocks. As a result, stop_repack_decoding_worker() is never called, leaving the decoding worker running indefinitely and holding its temporary replication slot.
Fix by using PG_ENSURE_ERROR_CLEANUP, which handles both ERROR and FATAL exits. Author: Baji Shaik <[email protected]> Reviewed-by: Sami Imseih <[email protected]> Reviewed-by: Álvaro Herrera <[email protected]> Discussion: https://postgr.es/m/ca+fm-rnopxl2n7db_a0anmxv_adu6jwj4pnoptmtbuapdpv...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0160143ad9a686a7e705348da1f90e63a2a31536 Modified Files -------------- src/backend/commands/repack.c | 42 +++++++++++++++++++++++++----------------- 1 file changed, 25 insertions(+), 17 deletions(-)
