Fix inconsistencies with pg_restore --statistics[-only]

Attempting to restore a schema, a table or an index with
--only-statistics skipped all the statistics of the objects wanted.
Like for pg_dump, statistics should be included, so this created an
assymetry between dump and restore.

A second set of problems existed for --table and --index, where the
presence of --statistics skipped the restore of the stats of the
object(s) targetted.

This issue has been reported originally as related to an inconsistency
with the way extended stats restore is handled in Postgres v19, but the
issue is related to the restore of relation and attribute statistics in
v18.  Some TAP tests are added to cover all these cases.

Reported-by: Chao Li <[email protected]>
Author: Chao Li <[email protected]>
Author: Michael Paquier <[email protected]>
Reviewed-by: Corey Huinker <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/42ffdedcf743c23ba346eba8e3afce9da5e8f618

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 36 ++++++++++++++++------
src/bin/pg_dump/t/002_pg_dump.pl     | 59 ++++++++++++++++++++++++++++++++++++
2 files changed, 86 insertions(+), 9 deletions(-)

Reply via email to