Fix ALTER DOMAIN VALIDATE CONSTRAINT locking Commit 16a0039dc0d1 reduced the lock level for ALTER DOMAIN ... VALIDATE CONSTRAINT from ShareLock to ShareUpdateExclusiveLock. However, that change was unsafe. If DML on tables using the domain had already started and initialized domain constraint checks before a NOT VALID constraint was added, it could still insert or update rows that violated the new constraint.
This commit reverts commit 16a0039dc0d1 so that ALTER DOMAIN ... VALIDATE CONSTRAINT once again acquires ShareLock on relations using the domain. Also add an isolation test covering this case. Author: Chao Li <[email protected]> Reviewed-by: Fujii Masao <[email protected]> Reviewed-by: Álvaro Herrera <[email protected]> Discussion: https://postgr.es/m/[email protected] Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/64797ad97d6e0a476f809979df99e0013c1933b1 Modified Files -------------- src/backend/commands/typecmds.c | 24 +++++------------ .../isolation/expected/alter-domain-validate.out | 23 +++++++++++++++++ src/test/isolation/isolation_schedule | 1 + .../isolation/specs/alter-domain-validate.spec | 30 ++++++++++++++++++++++ 4 files changed, 61 insertions(+), 17 deletions(-)
