Simplify some stats restore code with InputFunctionCallSafe() statatt_build_stavalues() and array_in_safe() have been relying on InitFunctionCallInfoData() with a locally-filled state to call a data type input function. InputFunctionCallSafe() can be used to achieve the same job, simplifying some code.
This fixes an over-allocation of FunctionCallInfoBaseData done in statatt_build_stavalues(), where there was space for 8 elements but only 3 were needed. The over-allocation exists since REL_18_STABLE, and was harmless in practice. While on it, fix some comments for both routines, where elemtypid was mentioned. Backpatch down to v19. This code has been reworked during the last development cycle while working on the restore of extended statistics, so this keeps the code consistent across all branches. Author: Jian He <[email protected]> Author: Michael Paquier <[email protected]> Discussion: https://postgr.es/m/CACJufxEGah9PaiTQ=cg14gmmbsuq3ohgct9tdswbmqpq0-n...@mail.gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ac536a4061bcf22db46ba23d077cd36e65e14e1a Modified Files -------------- src/backend/statistics/extended_stats_funcs.c | 17 +++-------------- src/backend/statistics/stat_utils.c | 23 ++++++----------------- 2 files changed, 9 insertions(+), 31 deletions(-)
