Switch Get[Local]BufferDescriptor() to use a signed value in input GetBufferDescriptor() and GetLocalBufferDescriptor() took a uint32 buffer index, but every real caller derives the index from a Buffer: - Unsigned value for shared buffers. - Signed value for local buffers.
Both routines now take in input a signed number, GetBufferDescriptor() gaining an assertion checking that the input value is in the range allowed by the GUC shared_buffers. This work is a follow-up of e18b0cb7344c, where we found that passing down a value for a local buffer was undetected and finished outside the range of NBuffers. While monitoring all the existing callers of *BufferDescriptor(), the only consumer that passes does an unsigned value is ClockSweepTick(), whose result is always a module of NBuffers. Suggested-by: Andres Freund <[email protected]> Author: Ayush Tiwari <[email protected]> Reviewed-by: Ashutosh Bapat <[email protected]> Reviewed-by: Michael Paquier <[email protected]> Discussion: https://postgr.es/m/caexhw5uzrmyvzsxxs3hxxt0fg_snrpuhuqwp4norhacqh9j...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ba4134075a822e119e2ca6c2718ff08ae9464a37 Modified Files -------------- src/include/storage/buf_internals.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
