Fix REPACK CONCURRENTLY for stored generated columns

In order to replay concurrent changes, REPACK CONCURRENTLY needs the
pg_attrdef tuples for the transient table to be there, in case a tuple
is modified concurrently with REPACK and requires to store the value
from the generated column (which, with the current arrangements, means
all tuples concurrently updated or inserted).  Fix by creating a copy of
them from the original table.  Add a test that tickles the bug.

Author: Antonin Houska <[email protected]>
Reported-by: Ewan Young <[email protected]>
Diagnosed-by: Ewan Young <[email protected]>
Reviewed-by: Ewan Young <[email protected]>
Backpatch-through: 19
Discussion: 
https://postgr.es/m/CAON2xHMrELwx9vKg6niSf8fMBA=-MGXmG=mpqu6+vmvhgjf...@mail.gmail.com

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fb284f2f9bdb9dd5e866132f7d0b8eeaa972e521

Modified Files
--------------
src/backend/commands/repack.c                      | 103 ++++++++++++++++++++-
.../modules/injection_points/specs/repack.spec     |   3 +-
2 files changed, 104 insertions(+), 2 deletions(-)

Reply via email to