Fix yet another portability problem in new NLS test. Álvaro reported offlist that his machine was passing the new-in-v19 nls.sql test in "make check" but not in "make installcheck". On investigation, the cause turned out to be that he has LANGUAGE set in his environment, and with (at least recent versions of) glibc that overrides LC_MESSAGES and friends, as per previous research by Bryan Green. "make check" works because pg_regress unsets LANGUAGE before starting the postmaster, but in installcheck mode we're exposed to the prevailing value and we lose.
We're already hacking the value of LANGUAGE in this test for Solaris, so let's just extend that to unsetting LANGUAGE on every other platform. Reported-by: Álvaro Herrera <[email protected]> Diagnosed-by: Andrew Dunstan <[email protected]> Author: Tom Lane <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5ed9cee74c6cf23729bd5cc4dee3b0ebbd4aa7aa Modified Files -------------- src/test/regress/regress.c | 6 ++++++ 1 file changed, 6 insertions(+)
