Remove Subscription conninfo field; generate in caller. After server-based subscriptions, conninfo became more than just a catalog field. It has its own error paths, and it's important that callers that don't need conninfo don't encounter errors related to it.
Reviewed-by: Amit Kapila <[email protected]> Reviewed-by: Hayato Kuroda (Fujitsu) <[email protected]> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8f7617ff7af60f4d9b2be0ba2d89b2fedbc027cc Modified Files -------------- src/backend/catalog/pg_subscription.c | 105 ++++++++++++++----------- src/backend/commands/subscriptioncmds.c | 43 +++++++--- src/backend/replication/logical/sequencesync.c | 2 +- src/backend/replication/logical/tablesync.c | 2 +- src/backend/replication/logical/worker.c | 24 +++++- src/include/catalog/pg_subscription.h | 6 +- src/include/replication/worker_internal.h | 1 + 7 files changed, 118 insertions(+), 65 deletions(-)
