Fix backend state after a failed after-startup shmem request RegisterShmemCallbacks() left the backend in a bad state, if an error occurred in the callbacks or if an allocation failed. Firstly, 'shmem_request_state' was left in wrong state, causing a subsequent call to RegisterShmemCallbacks() to wrongly take the postmaster startup codepath or assertion failures in some other functions. Secondly, the 'pending_shmem_requests' list was not properly cleaned up, causing a subsequent RegisterShmemCallbacks() to try to process the stale, already-freed requests.
To fix, add a PG_TRY() block to clean those things up on error. Author: Ayush Tiwari <[email protected]> Reviewed-by: Ashutosh Bapat <[email protected]> Discussion: https://www.postgresql.org/message-id/CAJTYsWVRRWH48=pcuao_2y4ap6m0qrmzxguffknrtdwk74l...@mail.gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/92d44b200e12c7ecbaee57d37fcd5e8803811358 Modified Files -------------- src/backend/storage/ipc/shmem.c | 74 +++++++++++++++------- .../modules/test_shmem/t/001_late_shmem_alloc.pl | 28 ++++++++ src/test/modules/test_shmem/test_shmem.c | 28 +++++++- 3 files changed, 105 insertions(+), 25 deletions(-)
