Stabilize recovery conflict stats checks in 031_recovery_conflict.pl The buildfarm member akepa reported a failure in the 031_recovery_conflict.pl test.
The test checked pg_stat_database_conflicts immediately after detecting a recovery conflict in the standby log. However, the conflict counter is flushed by the canceled backend during backend exit, so WAL replay completion and the log message did not guarantee that the updated statistics are visible yet. So, previously, the test could see a conflict counter of 0 even though the conflict had already occurred, triggering the test failure. Fix this by polling for the expected conflict counter instead of reading it only once, handling the asynchronous pgstats update. Per buildfarm member akepa. Backpatch to v17, where this test is enabled and has the same race. Author: Fujii Masao <[email protected]> Reviewed-by: Ayush Tiwari <[email protected]> Reviewed-by: Nazir Bilal Yavuz <[email protected]> Discussion: https://postgr.es/m/CAHGQGwHmiLNRfvJDAR=PmxQgf7DbzPSO1M-1RoqO8oy=t2g...@mail.gmail.com Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7d0a31fa22c8e830280e91e1a181d8be04e8632a Modified Files -------------- src/test/recovery/t/031_recovery_conflict.pl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
