Don't quote the relation name twice in EXCEPT clause errors. Commit a49b9cfd72 began reporting the EXCEPT clause relation with a schema-qualified name that quotes identifiers when needed, inside a message that already puts the name in quotes. So a schema or relation name that needs quoting came out quoted twice.
Fix by building the qualified name as "%s.%s" without identifier quoting, so it renders like the qualified names in other backend error messages. The message text, and so its translations, is unchanged. RelationGetQualifiedRelationName() has no callers left, so remove it. Author: Manuel Reyes Bravo <[email protected]> Reviewed-by: shveta malik <[email protected]> Reviewed-by: Vignesh C <[email protected]> Reviewed-by: Peter Smith <[email protected]> Reviewed-by: Zhijie Hou <[email protected]> Reviewed-by: Amit Kapila <[email protected]> Discussion: https://postgr.es/m/CAHGQGwHfESBexa7fq99EvFCf31av=o9h9udnw22ymxmm6lm...@mail.gmail.com Backpatch-through: 19, where it was introduced Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/926627bf9021137af66ac3bf21d1595af64ec66b Modified Files -------------- src/backend/catalog/pg_publication.c | 8 +++++++- src/backend/utils/cache/relcache.c | 10 ---------- src/include/utils/relcache.h | 1 - src/test/regress/expected/publication.out | 7 ++++++- src/test/regress/sql/publication.sql | 5 ++++- 5 files changed, 17 insertions(+), 14 deletions(-)
