Attempt to fix test interference from foreign_key opfamily test

The test added by c62b330912e creates a btree opfamily whose members
include built-in integer operators, which get_mergejoin_opfamilies()
finds regardless of schema.  So any concurrently running test that
planned an integer join or sort could pick the family up while it
existed.  That's the likely cause of the intermittent plan-shape
changes seen in window.sql and equivclass.sql on the buildfarm after
that commit.

Run the test inside a transaction that is rolled back, so the family
is never committed and never visible to other backends.

Per buildfarm members sifaka, prion, turaca, widowbird.

Discussion: 
https://postgr.es/m/CA+HiwqGitHCmO7nvV4nXXYWDkNYA+zVcJj=jnml3c1o9b0g...@mail.gmail.com
Backpatch-though: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f76c13edadc2b319036e0d238703ed56bb23f934

Modified Files
--------------
src/test/regress/expected/foreign_key.out | 19 +++++++++++--------
src/test/regress/sql/foreign_key.sql      | 19 +++++++++++--------
2 files changed, 22 insertions(+), 16 deletions(-)

Reply via email to