Remove RI fast-path code for calling cast functions

The previous commit stopped using the fast path when FK values need a
cast function, which leaves its code for calling them unused.  So
remove the following: the cached FmgrInfos for the cast and equality
functions and the memory context they used, the cast step in
build_index_scankeys(), the EXECUTE privilege check on the cast
function, and the unused forward declaration of RI_CompareHashEntry.

Also revert the changes made to ri_HashCompareOp() for the fast path's
cross-type operators and domain-typed keys in commits 2da86c1ef9 and
68ace967c1.  Fast-path code no longer uses the function.

Reviewed-by: Matheus Alcantara <[email protected]>
Discussion: 
https://postgr.es/m/cam527d9bgpjeooymbcbtd57r145qhck-dzw9qnq+nordq1j...@mail.gmail.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/964d88fac464a9b5f55c3d0c9c2ec72bcde5847d

Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 137 ++++++++++--------------------------
1 file changed, 39 insertions(+), 98 deletions(-)

Reply via email to