Fix ILIKE patterns with non-ASCII bytes in single-byte encodings. Commit 1e493158d3d changed the MATCH_LOWER implementation of GETCHAR() from SB_lower_char() to use pg_ascii_tolower(). The latter returns an unsigned char; but the local variable in C_IMatchText was a char.
For single-byte encodings and the C locale, that could lead to a broken signed/unsigned comparison. For example, the pattern U&'%\00C6' would never match. Fix by casting the result of pg_ascii_tolower() explicitly to char. Reported-by: Greg Burd <[email protected]> Reviewed-by: Greg Burd <[email protected]> Discussion: https://postgr.es/m/_GW2V-rd0QW4BTguAJriA9XVmjOn2mR3-YeAZr9ZU6EtlLvYPEm_r_fV5wGKzSNMzboj_nqn3fk72AYAvOKzEnPlCCHteaYrgESrIhPg6l8=@burd.me Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c00a97b646c04c0d895cca44a2b24ad7abec8a6c Modified Files -------------- src/backend/utils/adt/like_match.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
