Fix handling of some SQL/JSON locations in query jumbling GetJsonBehaviorConst() builds Const values for clauses like ON EMPTY or ON ERROR in SQL/JSON, and was setting up a location without considering the fact that these are not constants as per the query text: they are query keywords. For example "EMPTY ARRAY ON EMPTY" became "$2 ARRAY ON EMPTY", leading to confusing information reported for example in PGSS.
The Const nodes used by GetJsonBehaviorConst() is now left unset. The location was only used for an error position. This code path cannot be reached currently but we cannot use the expression location if not set; this spot is switched to the location of behavior keyword instead, which is better than nothing. This is obviously a bug. Unfortunately, no backpatch is done as this impacts the information of saved in PGSS and the shape of the Nodes themselves. Oversight in 6185c9737cf4. Author: Ilya Staroverov <[email protected]> Reviewed-by: Sami Imseih <[email protected]> Reviewed-by: Michael Paquier <[email protected]> Discussion: https://postgr.es/m/[email protected] Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1910daf98317bc321562e7d7436a791538825d0e Modified Files -------------- contrib/pg_stat_statements/expected/sqljson.out | 34 ++++++++++++------------- src/backend/parser/parse_expr.c | 9 +++---- 2 files changed, 21 insertions(+), 22 deletions(-)
