Fix error handling in pg_flush_data() and FilePrefetch() posix_fadvise() returns an error code directly instead of setting errno. However, pg_flush_data() uses %m and errcode_for_file_access() to report errors without setting errno, potentially reporting an unrelated error. Fix this by assigning the returned error code to errno before reporting the error.
FilePrefetch() is documented to return an errno error code on failure, but it returns -1 when FileAccess() fails. Fix this by returning errno instead. The first bug one only affects a warning, and the second doesn't have any effect because the only existing caller ignores the return value. So these are pretty harmless bugs, but let's be tidy. Author: Chao Li <[email protected]> Discussion: https://www.postgresql.org/message-id/[email protected] Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ce2797dca4f81bad7e4b838761bf717ceaaa584c Modified Files -------------- src/backend/storage/file/fd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
