Detach injection point at the end of repack_dropped isolation test. Commit e5d25959cf8 added the repack_dropped isolation test, which attaches the injection point repack-concurrently-before-lock as a local one but doesn't detach it. The injection point is then detached only when the session's backend exits, and isolationtester doesn't wait for that before starting the next test. If the backend is slow to exit, the next test that attaches the same injection point, currently repack_missingval, fails with an "already defined" error.
Fix by detaching it in the session's teardown, as the other REPACK tests do. Since the session that attached the injection point detaches it, the exiting backend no longer touches it. Reported-by: Hayato Kuroda <[email protected]> Author: Hayato Kuroda <[email protected]> Reviewed-by: Masahiko Sawada <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/92a74e26bbed36055e7776b354ea3d3118aafd75 Modified Files -------------- src/test/modules/injection_points/expected/repack_dropped.out | 5 +++++ src/test/modules/injection_points/specs/repack_dropped.spec | 5 +++++ 2 files changed, 10 insertions(+)
