ci: Use setup-msys2 instead of relocating preinstalled msys2 Previously we relocated the existing install, for performance reasons. However that has three disadvantages:
1) moving the install and then installing the packages we need is slower than just creating a new install 2) It hardcodes that D: is the fast drive, but that turns out to depend on the type of runner used 3) We were not using any caching and therefore downloaded the same files over and over. We could have added caching in the previous approach too, but it'd have been extra work. I previously prototyped handrolling the install, instead of using msys2/setup-msys2, and that does turn out to be a bit faster, but it doesn't include caching. By the time we add that, the overall complexity seems like it'd be too big. The other alternative would be to generate a downloadable release in the pg-vm-images repo. That'd likely be even faster. This removes the explicit use of CHERE_INVOKING as it is implied by using setup-msys2. This commit is backpatched to 19 to keep CI between master and 19 the same. Soon we'll backpatch CI support to regain coverage with lost with cirrus-ci's shutdown. Author: Andres Freund <[email protected]> Co-authored-by: Nazir Bilal Yavuz <[email protected]> Discussion: https://postgr.es/m/a2ejn7lfqolutzz7kozalbhy3bixdrujb4buc3pgbtlk4am2ba@wbv6v7riia33 Discussion: https://postgr.es/m/can55fz1bcwbswgcck2gqkyn6tzdxcw2hvk2m3qeiwanxunj...@mail.gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/009d8a5680fb2d3c11a7365ed109c83c8f47b597 Modified Files -------------- .github/workflows/pg-ci.yml | 78 +++++++++++++++++++++------------------------ 1 file changed, 36 insertions(+), 42 deletions(-)
