Fix Memoize using the wrong equality operator for cache keys

Memoize compared cache keys with the type's default equality operator
rather than the operator used by the parameterized join clause.  If a
hashable join operator considers fewer values equal than the type's
default equality operator, two outer values could share one cache
entry, and the inner rows cached for one value were returned for the
other.  One example is a byte-wise equality operator on a column with
a case-insensitive nondeterministic collation.

To fix, have check_memoizable() take the hash equality operators from
the clause's hashjoinoperator.  When both inputs are of the same type,
use the join operator itself.  For cross-type operators, look up the
same-type equality members in the join operator's hash opfamily.  If
no such member exists, don't set a hash equality operator, so Memoize
isn't used for that clause.  Clauses that aren't hashjoinable keep
using the type's default equality operator along with binary mode, as
before.

Backpatch to all supported versions.

Bug: #19853
Reported-by: chunling qin <[email protected]>
Author: David Rowley <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a9ad341bd6862c4cbc220b9a2835c794fab7114f

Modified Files
--------------
src/backend/optimizer/plan/initsplan.c         | 57 ++++++++++++++++++-------
src/test/regress/expected/collate.icu.utf8.out | 58 ++++++++++++++++++++++++++
src/test/regress/sql/collate.icu.utf8.sql      | 41 ++++++++++++++++++
3 files changed, 141 insertions(+), 15 deletions(-)

Reply via email to