Prevent ALTERing a row type that's concurrently used in a column

ALTER TABLE/TYPE checks if the type is being used in a column and
forbids it, because that would require rewriting the data in the
affected table.  But the check missed cases where the type was
concurrently used in a CREATE TABLE or ALTER TABLE ADD COLUMN that
hasn't committed yet.

Commit 2fbb21170e fixed a similar race condition for dropping the
column type altogether, but it wasn't sufficient to fix the problem
with altering the type, because altering a composite type doesn't
currently lock the type.  It does lock the *relation* corresponding to
the type (i.e. pg_type.typrelid), but CREATE TABLE did not hold onto
that lock, even though it acquires it momentarily.  To fix, don't
release the lock.

Reviewed-by: Andres Freund <[email protected]>
Security: CVE-2026-6460
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e00986934cd0669ee3324b1cb518d5d781084c49
Author: Heikki Linnakangas <[email protected]>

Modified Files
--------------
src/backend/catalog/heap.c                       |   7 +-
src/test/isolation/expected/type-ddl-locking.out | 109 ++++++++++++++++
src/test/isolation/isolation_schedule            |   1 +
src/test/isolation/specs/type-ddl-locking.spec   | 157 +++++++++++++++++++++++
4 files changed, 273 insertions(+), 1 deletion(-)

Reply via email to