xid_wraparound: Fix XID consumption accounting

When the current transaction had not yet been assigned a top-level
XID, consume_xids(n) consumed n + 1 XIDs because the initial top-level
XID allocation was not included in the count. Include that allocation
so that the function consumes exactly n XIDs.

In particular, consume_xids(1) now consumes and returns only the
top-level XID in this case, rather than consuming two XIDs and
returning the second. consume_xids(0) now raises an error instead of
returning the next unallocated XID.

With 32kB blocks, bulk XID consumption could also consume more XIDs
than requested or return an outdated XID. Restrict this optimization
so that consume_xids(n) always consumes exactly n XIDs and returns
the last XID it assigned.

Backpatch to 17, where the xid_wraparound test module was introduced.

Author: Yushi Ogiwara <[email protected]>
Author: João Rito <[email protected]>
Reviewed-by: Masahiko Sawada <[email protected]>
Reviewed-by: Fujii Masao <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1b4abc23f3e3fa8f2274b74b7912c90bed31b242

Modified Files
--------------
src/test/modules/xid_wraparound/xid_wraparound.c | 52 ++++++++++++++++--------
1 file changed, 36 insertions(+), 16 deletions(-)

Reply via email to